Github user nir-sopher commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/752#discussion_r130238764
--- Diff: traffic_ops/app/lib/API/Server.pm ---
@@ -569,10 +575,17 @@ sub get_unassigned_servers_by_dsid {
$ds_server_criteria{'deliveryservice.id'} = $ds_id;
my @assigned_servers;
- if ( &is_privileged($self) ||
$self->is_delivery_service_assigned($ds_id) ) {
+ my $tenant_utils = Utils::Tenant->new($self);
+ my $tenants_data = $tenant_utils->create_tenants_data_from_db();
+
+ if (!$tenant_utils->is_ds_resource_accessible($tenants_data,
$ds->tenant_id)) {
+ return $self->forbidden();
+ }
+ elsif ( &is_privileged($self) || $tenant_utils->ignore_ds_users_table()
|| $self->is_delivery_service_assigned($ds_id) ) {
@assigned_servers =
$self->db->resultset('DeliveryserviceServer')->search( \%ds_server_criteria, {
prefetch => [ 'deliveryservice', 'server' ] } )->get_column('server')->all();
}
else {
+ #for the reviewer - I believe it should turn into forbidden as
well
--- End diff --
Fixed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
