[
https://issues.apache.org/jira/browse/TC-502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16118641#comment-16118641
]
ASF GitHub Bot commented on TC-502:
-----------------------------------
Github user dangogh commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/785#discussion_r131972340
--- Diff: traffic_ops/bin/traffic_ops_ort.pl ---
@@ -1266,15 +1266,19 @@ sub check_plugins {
( my @parts ) = split( /\@plugin\=/, $liner );
foreach my $i ( 1..$#parts ) {
( my $plugin_name, my $plugin_config_file ) =
split( /\@pparam\=/, $parts[$i] );
- if (defined( $plugin_config_file ) ) {
+ if (defined( $plugin_config_file ) ) {{
--- End diff --
looking again -- that block isn't necessary -- the `last` will exit the
nearest enclosing loop, which is the `foreach ... $#parts)`
> ORT fails to handle non-file arguments
> --------------------------------------
>
> Key: TC-502
> URL: https://issues.apache.org/jira/browse/TC-502
> Project: Traffic Control
> Issue Type: Bug
> Components: Traffic Ops ORT
> Reporter: Chris Lemmons
>
> ORT currently processes the parameters of all plugins on the remap.config
> line as though they were files. However, parameters to `cachekey.config` are
> parsed as parameters directly on the remap line. So, for example, if you have
> a remap line that contains something like this:
> {{@plugin=cachekey.so @pparam=--remove-path=true}}
> That will cause ORT to attempt to load a config file named
> {{--remove-path=true}}. ORT fails to accomplish this in several ways and
> produces a variety of errors:
> DEBUG Starting processing of config file: --remove-path=true
> WARN --remove-path=true is being processed with an unknown service
> {code:none}
> INFO: ======== Start processing config file: --remove-path=true ========
> Use of uninitialized value in concatenation (.) or string at
> /opt/ort/traffic_ops_ort.pl line 2515.
> Use of uninitialized value $dir in -d at /opt/ort/traffic_ops_ort.pl line 645.
> Use of uninitialized value $dir in concatenation (.) or string at
> /opt/ort/traffic_ops_ort.pl line 648.
> /bin/mkdir: missing operand
> Try '/bin/mkdir --help' for more information.
> Use of uninitialized value $dir in pattern match (m//) at
> /opt/ort/traffic_ops_ort.pl line 649.
> Use of uninitialized value $dir in pattern match (m//) at
> /opt/ort/traffic_ops_ort.pl line 653.
> Use of uninitialized value $dir in concatenation (.) or string at
> /opt/ort/traffic_ops_ort.pl line 657.
> DEBUG Directory created: .
> Use of uninitialized value $result in pattern match (m//) at
> /opt/ort/traffic_ops_ort.pl line 2482.
> Use of uninitialized value $size in numeric eq (==) at
> /opt/ort/traffic_ops_ort.pl line 2488.
> Use of uninitialized value $url in concatenation (.) or string at
> /opt/ort/traffic_ops_ort.pl line 2489.
> ERROR URL: returned empty!
> {code}
> ORT should probably skip "files" that start with {{-}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
