[ https://issues.apache.org/jira/browse/TC-187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16130656#comment-16130656 ]
ASF GitHub Bot commented on TC-187: ----------------------------------- Github user rawlinp commented on a diff in the pull request: https://github.com/apache/incubator-trafficcontrol/pull/360#discussion_r133737928 --- Diff: traffic_ops/app/lib/API/DeliveryService/SslKeys.pm --- @@ -120,12 +120,23 @@ sub view_by_xml_id { if ( !$version ) { $version = 'latest'; } - $key = "$key-$version"; + my $ds = $self->db->resultset('Deliveryservice')->search( { xml_id => $xml_id })->single(); + if (!$ds) { + return $self->alert( { Error => " - Could not found delivery service with xml_id=$xml_id!" } ); + } + my $ds_id = $ds->id; + my $key = "ds_$ds_id-$version"; --- End diff -- This has the effect of not being able to find any preexisting keys for delivery services. Will all existing keys need to be re-added because of this change? > Update delivery service makes SSL keys invalid > ---------------------------------------------- > > Key: TC-187 > URL: https://issues.apache.org/jira/browse/TC-187 > Project: Traffic Control > Issue Type: Bug > Components: Traffic Ops > Reporter: Zhilin Huang > Assignee: Zhilin Huang > Labels: ssl, xml-id > > Modify xml-id or subdomain in a https delivery service will make existing SSL > keys invalid. > And there is problem to generate keys if using "http and https" together with > 1 host_regex, and 1 path_regex. > BTW, the certificate returned by RESTful API is not consistent with that GUI. -- This message was sent by Atlassian JIRA (v6.4.14#64029)