Github user mitchell852 commented on a diff in the pull request:

    
https://github.com/apache/incubator-trafficcontrol/pull/790#discussion_r134322763
  
    --- Diff: traffic_ops/app/lib/API/DeliveryService/KeysUrlSig.pm ---
    @@ -26,6 +26,32 @@ use constant URL_SIG_KEYS_BUCKET => "url_sig_keys";
     use Exporter qw(import);
     our @EXPORT_OK = qw(URL_SIG_KEYS_BUCKET);
     
    +
    +sub view_by_id {
    +   my $self                = shift;
    +   my $id              = $self->param('id');
    +   my $rs = $self->db->resultset("Deliveryservice")->find( { id => $id } 
); 
    +   my $xml_id;
    +   if ( defined($rs) ) {
    +           $xml_id = $rs->xml_id;
    +   }
    +   else {
    +           return $self->alert("Delivery Service '$id' does not exist.");
    +   }
    +
    --- End diff --
    
    can you add a tenant check in here similar to this:
    
    
https://github.com/apache/incubator-trafficcontrol/blob/master/traffic_ops/app/lib/API/Deliveryservice.pm#L175
     
    going forward, anything ds related needs to check that the user requesting 
the ds info has the proper tenant to do so. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to