[
https://issues.apache.org/jira/browse/TC-187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16136581#comment-16136581
]
ASF GitHub Bot commented on TC-187:
-----------------------------------
Github user zhilhuan commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/360#discussion_r134432509
--- Diff: traffic_ops/app/lib/UI/DeliveryService.pm ---
@@ -152,12 +153,7 @@ sub get_example_urls {
}
}
elsif ( $re->{type} eq 'PATH_REGEXP' ) {
- if ( defined( $example_urls[ $re->{set_number}
] ) ) {
- $example_urls[ $re->{set_number} ] .=
$re->{pattern};
- }
- else {
- $example_urls[ $re->{set_number} ] =
$re->{pattern};
- }
+ push(@example_urls, $re->{pattern});
--- End diff --
It messed up when both "HOST_REGEXP" and "PATH_REGEXP" configured. Root
cause:
1. Duplicated "set_number" is not allowed in DS configuration in GUI. So
not "PATH_REGEXP" will share the same "set_number" with "HOST_REGEXP".
2. "$re->{set_number}" is not the index of "@example_urls". See the "push(
@example_urls, $https_url );" code above. So "$example_urls[ $re->{set_number}
] .= $re->{pattern};" may mess up with any other "HOST_REGEXP".
> Update delivery service makes SSL keys invalid
> ----------------------------------------------
>
> Key: TC-187
> URL: https://issues.apache.org/jira/browse/TC-187
> Project: Traffic Control
> Issue Type: Bug
> Components: Traffic Ops
> Reporter: Zhilin Huang
> Assignee: Zhilin Huang
> Labels: ssl, xml-id
>
> Modify xml-id or subdomain in a https delivery service will make existing SSL
> keys invalid.
> And there is problem to generate keys if using "http and https" together with
> 1 host_regex, and 1 path_regex.
> BTW, the certificate returned by RESTful API is not consistent with that GUI.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
