[ 
https://issues.apache.org/jira/browse/TC-540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16137440#comment-16137440
 ] 

ASF GitHub Bot commented on TC-540:
-----------------------------------

GitHub user dangogh opened a pull request:

    https://github.com/apache/incubator-trafficcontrol/pull/854

    [TC-540] postinstall ldap.conf keys fixed; cdn.conf base_url added

    keys for ldap.conf were incorrect and caused traffic_ops not to connect to 
ldap.   cdn.conf base_url question was missed causing base_url in existing 
cdn.conf to be unchanged.
    
    Both of these were fixed.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dangogh/incubator-trafficcontrol ldap-fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-trafficcontrol/pull/854.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #854
    
----
commit 1d80843aabeaebbb7f2581d7772dd74b4fe57c0f
Author: Dan Kirkwood <dang...@gmail.com>
Date:   2017-08-18T18:44:33Z

    required keys in ldap.conf; check host form; add base_url to defaults and 
q's

commit 9419bb8e52b6c0423e69fc2492537dd97354acbf
Author: Dan Kirkwood <dang...@gmail.com>
Date:   2017-08-22T20:57:22Z

    updates base_url

----


> TO postinstall writes incorrect keys to ldap.conf
> -------------------------------------------------
>
>                 Key: TC-540
>                 URL: https://issues.apache.org/jira/browse/TC-540
>             Project: Traffic Control
>          Issue Type: Bug
>          Components: Traffic Ops
>    Affects Versions: 2.1.0
>            Reporter: Dan Kirkwood
>            Assignee: Dan Kirkwood
>            Priority: Blocker
>             Fix For: 2.1.0
>
>
> I think this needs to be fixed for 2.1.
> postinstall writes incorrect keys to /opt/traffic_ops/app/conf/ldap.conf -- 
> they should be:
> {quote}
>    "host"
>    "admin_dn" 
>    "admin_pass" 
>    "search_base"
> {quote}
> but the keys that show up are:
> {quote}
>    "password"
>    "search_base"
>    "hostname" 
>    "admin_dn" 
>    "setupLdap"
> {quote}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to