dangogh commented on a change in pull request #1800: Fix deep_caching_type
validator regex
URL:
https://github.com/apache/incubator-trafficcontrol/pull/1800#discussion_r164228247
##########
File path: traffic_ops/app/lib/API/Deliveryservice.pm
##########
@@ -1387,7 +1387,7 @@ sub is_deliveryservice_valid {
active => [ is_required("is
required") ],
cdnId => [ is_required("is
required"), \&is_valid_int_or_undef ],
ccrDnsTtl => [
\&is_valid_int_or_undef ],
- deepCachingType => [ is_like( qr/^NEVER|ALWAYS$/,
"must be NEVER or ALWAYS" ) ],
+ deepCachingType => [ is_like(
qr/^(NEVER|ALWAYS)$/, "must be NEVER or ALWAYS" ) ],
Review comment:
really minor nit.. looks like current code is using TABs to align the
arrows.. can you match?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
