alficles commented on a change in pull request #1799: Traffic Ops API/GUI
configuration of FQ Pacing plugin
URL:
https://github.com/apache/incubator-trafficcontrol/pull/1799#discussion_r165081613
##########
File path: traffic_ops/app/templates/delivery_service/_form.html.ep
##########
@@ -399,6 +399,17 @@
%= field('ds.global_max_tps')->text(class => 'field', readonly
=> 'readonly');
<% } %>
</div>
+ <div class="block form-row" id="fq_pacing_rate_row">
+ <% unless (field('ds.fq_pacing_rate')->valid) { %>
+ <span class="field-with-error"><%=
field('ds.fq_pacing_rate')->error %></span>
+ <% } %>
+ %= label_for 'fq_pacing_rate' => 'Max Bytes per Second allowed
per session (3000k or 5M are valid entries)', class => 'label'
Review comment:
So, if someone writes `3T`, it stores `3000000000` in the DB. And then when
someone goes to edit the field a second time, it will just appear as
`3000000000`, instead of being displayed as `3T`? That seems odd, but might be
consistent with our other behaviour.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
