rob05c commented on issue #1844: DeepCachingType -- "NEVER" is now default
URL: 
https://github.com/apache/incubator-trafficcontrol/pull/1844#issuecomment-362658489
 
 
   Looks good! Sorry about the delay, I didn't think about JSON at first. 
   
   Again, there is no perfect solution, but IMO this is the best option, it 
gives us a correct default that serializes and stringifies correctly, and works 
if someone default-constructs either the enum or things containing it, 
`DeepCachingType{}` or `DeliveryService{}`.
   
   A `type DeepCachingType struct{s string}; const DeepCachingTypeAlways  = 
DeepCachingType{s: "ALWAYS"}` would be a perfect solution that prevented wrong 
`string(t)` calls, but Go doesn't allow const structs :(
   
   As the RM, I'll make sure this gets in 2.2.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to