nir-sopher commented on issue #1859: cr-config: calculating the hash-id if needed URL: https://github.com/apache/incubator-trafficcontrol/pull/1859#issuecomment-364213554 As far as I tested, empty string is "false". Nir On Feb 8, 2018 7:40 PM, "Jeremy Mitchell" <[email protected]> wrote: > *@mitchell852* commented on this pull request. > ------------------------------ > > In traffic_ops/app/lib/UI/Topology.pm > <https://github.com/apache/incubator-trafficcontrol/pull/1859#discussion_r167013045> > : > > > @@ -264,7 +264,7 @@ sub gen_crconfig_json { > $data_obj->{'contentServers'}->{ $row->host_name }->{'ip6'} = ( $row->ip6_address || "" ); > $data_obj->{'contentServers'}->{ $row->host_name }->{'profile'} = $row->profile->name; > $data_obj->{'contentServers'}->{ $row->host_name }->{'type'} = $row->type->name; > - $data_obj->{'contentServers'}->{ $row->host_name }->{'hashId'} = $row->xmpp_id; > + $data_obj->{'contentServers'}->{ $row->host_name }->{'hashId'} = $row->xmpp_id ? $row->xmpp_id : $row->host_name; > > would this allow an xmpp_id = "" which would probably not be a good thing. > do we need a better test like isDefined and neq empty string? > > ? > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <https://github.com/apache/incubator-trafficcontrol/pull/1859#pullrequestreview-95167041>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AXGkYGJv9rq3-f5LYh8robfST7KruxYBks5tSzGVgaJpZM4R9evn> > . >
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
