mitchell852 commented on a change in pull request #1867: Job deletion API
URL: 
https://github.com/apache/incubator-trafficcontrol/pull/1867#discussion_r167255532
 
 

 ##########
 File path: traffic_ops/app/lib/API/Job.pm
 ##########
 @@ -113,6 +113,29 @@ sub show {
        $self->success( \@data );
 }
 
+
+sub delete {
 
 Review comment:
   I think you need to check tenancy on this method. you can't delete a job 
outside of your tenancy, right? the job table has a job_deliveryservice column 
that you can use to check tenancy...

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to