limited commented on a change in pull request #1866: Added
maxmind.default.override parameter to CRConfig to handle maxmind default
locations
URL:
https://github.com/apache/incubator-trafficcontrol/pull/1866#discussion_r169673451
##########
File path:
traffic_router/core/src/main/java/com/comcast/cdn/traffic_control/traffic_router/core/router/TrafficRouter.java
##########
@@ -86,6 +87,8 @@
private final ConsistentHasher consistentHasher = new
ConsistentHasher();
private SteeringRegistry steeringRegistry;
+ private final Map<String, Geolocation> defaultGeolocations = new
HashMap<String, Geolocation>();
Review comment:
nitpick, but variable might be more clear named defaultGeolocationsOverride.
Skimming the code I got this confused with defaultLocation (which is what we
call a geolocation from Maxmind w/o a city or postal code)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
