DylanVolz commented on a change in pull request #1922: TO golang -- add 
capability for custom changelog message per object type
URL: 
https://github.com/apache/incubator-trafficcontrol/pull/1922#discussion_r170396883
 
 

 ##########
 File path: traffic_ops/traffic_ops_golang/deliveryservice/request/requests.go
 ##########
 @@ -430,6 +430,20 @@ func (req *TODeliveryServiceRequest) Delete(db *sqlx.DB, 
user auth.CurrentUser)
        return nil, tc.NoError
 }
 
+// ChangeLogMessage implements the api.ChangeLogger interface for a custom log 
message
+func (req *TODeliveryServiceRequest) ChangeLogMessage(action string, db 
*sqlx.DB) (string, error) {
 
 Review comment:
   Why does ChangeLogMessage take a db handle as an argument? Will there be 
cases were constructing a struct's log message requires querying the db?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to