alficles commented on a change in pull request #1950: Added CRUD for /parameters
URL: 
https://github.com/apache/incubator-trafficcontrol/pull/1950#discussion_r171947162
 
 

 ##########
 File path: traffic_ops/traffic_ops_golang/systeminfo/system_info.go
 ##########
 @@ -87,15 +88,18 @@ WHERE p.config_file='global'`
 
        info := make(map[string]string)
        for rows.Next() {
-               p := tc.Parameter{}
+               p := tc.ParameterNullable{}
                if err = rows.StructScan(&p); err != nil {
                        return nil, fmt.Errorf("getting system_info: %v", err)
                }
-               if p.Secure && privLevel < auth.PrivLevelAdmin {
+               isSecure := *p.Secure
 
 Review comment:
   This will panic if p.Secure is null, which it will be if it's missing.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to