Vijay-1 commented on issue #1908: Changes for Backup Edge Cache Group URL: https://github.com/apache/incubator-trafficcontrol/pull/1908#issuecomment-371539718 @rawlinp I agree that we should be using track across. I decided against it because i thought it would add more changes. I have now changed the code using track. Given below is some of the deviation i took from your comments. 1. I didnt use DS_CZ_NO_BKP, since all the failures will be validated against bypass setting and that is what will get tagged in the end. Even if we mark it with DS_CZ_NO_BKP, it will get replaced by NO_BYPASS i believe. I think , we can leave it this way since a successful fetch gets tagged properly. 2. I used a boolean variable to keep track of fallbacktoNextGroup flag and used it to decide on get lookups. 3. Looks like changing the data type of getCoverageZoneLocation, leaving out a boolean keeping false as default is not possible because getDeepCoverageZoneCacheLocation uses true. 4. I believe , i have resolved conflicts in CHANGELOG. IPlease let me know if i missed anything. 5. I have not tested these changes since my test bed is down temporarily. Hosted for review without testing to give you a heads up on how i am planning to address your comments.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
