dangogh commented on a change in pull request #1993: [Issue-1617] - Traffic Ops Keeps track of configuration differences between database and Traffic Servers URL: https://github.com/apache/incubator-trafficcontrol/pull/1993#discussion_r173949430
########## File path: traffic_ops/traffic_ops_golang/cfgdiffs.go ########## @@ -0,0 +1,303 @@ +package main + +import ( + "database/sql" + "encoding/json" + "errors" + "fmt" + "net/http" + + "github.com/apache/incubator-trafficcontrol/lib/go-log" + "github.com/apache/incubator-trafficcontrol/traffic_ops/traffic_ops_golang/auth" + + "github.com/jmoiron/sqlx" +) + +const CfgDiffsPrivLevel = auth.PrivLevelReadOnly +const CfgDiffsWritePrivLevel = auth.PrivLevelOperations + Review comment: these PrivLevel consts should go away -- we're using the `auth.PrivLevel...` consts to control individual routes in `routes.go` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
