mitchell852 commented on a change in pull request #2029: Implements
https://github.com/apache/incubator-trafficcontrol/issues/…
URL:
https://github.com/apache/incubator-trafficcontrol/pull/2029#discussion_r177819273
##########
File path: traffic_ops/app/lib/TrafficOpsRoutes.pm
##########
@@ -418,6 +418,13 @@ sub api_routes {
$r->put("/api/$version/cachegroups/:id" => [ id => qr/\d+/ ] )->over(
authenticated => 1, not_ldap => 1 )->to( 'Cachegroup#update', namespace =>
$namespace );
$r->delete("/api/$version/cachegroups/:id" => [ id => qr/\d+/ ]
)->over( authenticated => 1, not_ldap => 1 )->to( 'Cachegroup#delete',
namespace => $namespace );
+
+ # -- CACHEGROUP-Fallbacks: CRUD
+ $r->get("/api/$version/cachegroups/:id/fallbacks" => [ id => qr/\d+/ ]
)->over( authenticated => 1, not_ldap => 1 )->to( 'CachegroupFallback#show',
namespace => $namespace );
+ $r->post("/api/$version/cachegroups/:id/fallbacks" => [ id => qr/\d+/ ]
)->over( authenticated => 1, not_ldap => 1 )->to( 'CachegroupFallback#create',
namespace => $namespace );
Review comment:
what happens if i do 2 POSTs in a row. does the 2nd POST wipe out the
fallbacks of the first or does it add to it?
what is the intent of PUT? does a PUT wipe out all the fallbacks and replace
them?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
