mitchell852 closed pull request #2073: fixed compiler errors in the API tests
URL: https://github.com/apache/incubator-trafficcontrol/pull/2073
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/traffic_ops/testing/api/v13/cdns_test.go
b/traffic_ops/testing/api/v13/cdns_test.go
index 2c9ab4c2d..a3fe7f5fb 100644
--- a/traffic_ops/testing/api/v13/cdns_test.go
+++ b/traffic_ops/testing/api/v13/cdns_test.go
@@ -49,7 +49,7 @@ func UpdateTestCDNs(t *testing.T) {
// Retrieve the CDN by name so we can get the id for the Update
resp, _, err := TOSession.GetCDNByName(firstCDN.Name)
if err != nil {
- t.Errorf("cannot GET CDN by name: '%s' %v - %v\n",
firstCDN.Name, err)
+ t.Errorf("cannot GET CDN by name: '%s', %v\n", firstCDN.Name,
err)
}
remoteCDN := resp[0]
expectedCDNDomain := "domain2"
@@ -63,7 +63,7 @@ func UpdateTestCDNs(t *testing.T) {
// Retrieve the CDN to check CDN name got updated
resp, _, err = TOSession.GetCDNByID(remoteCDN.ID)
if err != nil {
- t.Errorf("cannot GET CDN by name: '$%s' %v - %v\n",
firstCDN.Name, err)
+ t.Errorf("cannot GET CDN by name: '$%s', %v\n", firstCDN.Name,
err)
}
respCDN := resp[0]
if respCDN.DomainName != expectedCDNDomain {
diff --git
a/traffic_ops/testing/api/v13/deliveryservice_request_comments_test.go
b/traffic_ops/testing/api/v13/deliveryservice_request_comments_test.go
index b5eda0083..40fda203e 100644
--- a/traffic_ops/testing/api/v13/deliveryservice_request_comments_test.go
+++ b/traffic_ops/testing/api/v13/deliveryservice_request_comments_test.go
@@ -72,7 +72,7 @@ func UpdateTestDeliveryServiceRequestComments(t *testing.T) {
// Retrieve the delivery service request comment to check that the
value got updated
resp, _, err :=
TOSession.GetDeliveryServiceRequestCommentByID(firstComment.ID)
if err != nil {
- t.Errorf("cannot GET delivery service request comment by id:
'$%s' %v - %v\n", firstComment.ID, err)
+ t.Errorf("cannot GET delivery service request comment by id:
'$%d', %v\n", firstComment.ID, err)
}
respDSRC := resp[0]
if respDSRC.Value != newFirstCommentValue {
@@ -100,7 +100,7 @@ func DeleteTestDeliveryServiceRequestComments(t *testing.T)
{
for _, comment := range comments {
_, _, err :=
TOSession.DeleteDeliveryServiceRequestCommentByID(comment.ID)
if err != nil {
- t.Errorf("cannot DELETE delivery service request
comment by id: '%s' %v\n", comment.ID, err)
+ t.Errorf("cannot DELETE delivery service request
comment by id: '%d' %v\n", comment.ID, err)
}
// Retrieve the delivery service request comment to see if it
got deleted
@@ -109,7 +109,7 @@ func DeleteTestDeliveryServiceRequestComments(t *testing.T)
{
t.Errorf("error deleting delivery service request
comment: %s\n", err.Error())
}
if len(comments) > 0 {
- t.Errorf("expected delivery service request comment: %s
to be deleted\n", comment.ID)
+ t.Errorf("expected delivery service request comment: %d
to be deleted\n", comment.ID)
}
}
}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
