Vijay-1 commented on issue #2029: Implements https://github.com/apache/incubator-trafficcontrol/issues/… URL: https://github.com/apache/incubator-trafficcontrol/pull/2029#issuecomment-378280795 In perl/ Mojo, i can see this query params only for indexes, where we are fetching an entire set and ordering , say for example all available cache groups/ delivery services etc and ordering them by id / name etc. But in this case we always go by a specific cache id. When i fetch data for /api/cachegroup_fallbacks?cgid=1, i have to return results in a particular format and for ?fbid, i have to pack results in particular format. Say for example: for /cachegroup_fallbacks?fallbackId=5 GET response may be a list of cache groups which has server 5 as backup {"response":{"fallbackID":"5","list":["GROUP1","GROUP2"]}} whereas /cachegroup_fallbacks?cacheGroupId=5 Backup configuration for server 5 along with its order {"response":[{"cacheGroupId":"1","order":9,"name":"GROUP6"},{"cacheGroupId":"1","order":10,"name":"GROUP2"}]} is that what you meant? I dont think current Perl/ Mojo implementation has any thing of this sort. AFIK, the only point i see in supporting these APIs is the similarity it may share with GO APIs. Is this alone is enough to change nested routes to the ones which supports query params? Why cant we leave this as such for Perl / Mojo?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
