dangogh commented on a change in pull request #2010: Go login
URL: 
https://github.com/apache/incubator-trafficcontrol/pull/2010#discussion_r179322637
 
 

 ##########
 File path: traffic_ops/install/bin/_postinstall
 ##########
 @@ -262,13 +262,15 @@ sub generateLdapConf {
         }
     }
 
-    my @requiredKeys = qw{ host admin_dn admin_pass search_base };
+    my @requiredKeys = qw{ host admin_dn admin_pass search_base search_query 
insecure ldap_timeout_secs };
     for my $k (@requiredKeys) {
         if (! exists $ldapConf{$k} ) {
             errorOut("$k is a required key in $fileName");
         }
     }
 
+    delete $ldapConf{setupLdap}
+
 
 Review comment:
   syntax error here -- missing `;` at the end of that `delete`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to