mitchell852 commented on a change in pull request #2158: modifies ORT to
correctly parse api 1.3 for revalidation.
URL:
https://github.com/apache/incubator-trafficcontrol/pull/2158#discussion_r183714002
##########
File path: traffic_ops/bin/traffic_ops_ort.pl
##########
@@ -783,6 +771,53 @@ sub get_print_current_client_connections {
( $log_level >> $DEBUG ) && print "DEBUG There are currently
$current_connections connections.\n";
}
+sub get_update_status {
+ my $status_api;
+ my $uri = "/api/1.3/servers/$hostname_short/update_status";
Review comment:
I don't understand why this route would not exist
(/api/1.3/servers/$hostname_short/update_status). If it doesn't exist, then TO
needs to be upgraded so it does exist. By falling back to
/update/$hostname_short you are going to have major issues when
/update/$hostname_short is eventually deprecated.
IMO "UI" routes like /update/$hostname_short need to be removed from ORT
entirely and ORT needs to leverage real API endpoints or it runs the risk of
not working at all as TO evolves away from the UI namespace.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
