rob05c commented on a change in pull request #2191: revert changes that broke
perl unit tests
URL:
https://github.com/apache/incubator-trafficcontrol/pull/2191#discussion_r185231007
##########
File path: traffic_ops/app/lib/TrafficOpsRoutes.pm
##########
@@ -449,6 +449,13 @@ sub api_routes {
# -- CDNS: ROUTING
$r->get("/api/$version/cdns/routing")->over( authenticated => 1,
not_ldap => 1 )->to( 'Cdn#routing', namespace => $namespace );
+ # -- CDNS: SNAPSHOT
+ $r->get("/api/$version/cdns/:name/snapshot")->over( authenticated => 1,
not_ldap => 1 )->to( 'Topology#get_snapshot', namespace => $namespace );
+ $r->get("/api/$version/cdns/:name/snapshot/new")->over( authenticated
=> 1, not_ldap => 1 )->to( 'Topology#get_new_snapshot', namespace => $namespace
);
+ $r->put( "/api/$version/cdns/:id/snapshot" => [ id => qr/\d+/ ]
)->over( authenticated => 1, not_ldap => 1 )
+ ->to( 'Topology#SnapshotCRConfig', namespace => $namespace );
+ $r->put("/api/$version/snapshot/:cdn_name")->over( authenticated => 1,
not_ldap => 1 )->to( 'Topology#SnapshotCRConfig', namespace => $namespace );
Review comment:
What tests are relying on these endpoints? If it's only the CRConfig tests,
we can remove those, right?
I'm wondering what else, to know if we should do those endpoints in Go next.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
