rob05c commented on issue #2010: Go login
URL: 
https://github.com/apache/incubator-trafficcontrol/pull/2010#issuecomment-388499921
 
 
   I think this needs to check for the `ldap.conf` file in the same way the 
existing Perl does
   
https://github.com/apache/incubator-trafficcontrol/blob/master/traffic_ops/app/lib/TrafficOps.pm#L502
   
https://github.com/apache/incubator-trafficcontrol/blob/master/traffic_ops/app/lib/TrafficOps.pm#L414
   
   Making it configurable is good, but we should support the existing method 
too, and not require a config change on upgrade.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to