[ https://issues.apache.org/jira/browse/TS-1035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13192951#comment-13192951 ]
Brian Geffon commented on TS-1035: ---------------------------------- So I have an issue here, I wanted to make MAX_EVENT_THREADS and MAX_THREADS_IN_EACH_TYPE records.configurable and what I realized is that EventProcessor is statically constructed so I won't have access to records.config when the event processor is constructed. Any suggestions? i'm thinking at this point it might just make more sense to set the limits high since the memory overhead is negligible (it's an array of MAX_EVENT_THREAD pointers) rather than making it configurable, thoughts? > EventProcessor::spawn_thread doesn't check that there is enough event threads > and segfaults > ------------------------------------------------------------------------------------------- > > Key: TS-1035 > URL: https://issues.apache.org/jira/browse/TS-1035 > Project: Traffic Server > Issue Type: Bug > Components: Core > Affects Versions: 3.0.1 > Reporter: Brian Geffon > Assignee: Brian Geffon > Fix For: 3.1.3 > > Attachments: LargeNumberOfPorts.patch, UnixEventProcessor.patch > > > The easiest way to see this bug is to use several hundred ports with accept > threads turned on. The bug exists because in I_EventProcessor.h there is a > hard coded limit of 512 event threads and there is no check in spawn_thread > that you haven't exceeded that limit so it will result in a segfault if > you're creating too many threads. From what I can tell the best solution is > an assertion that you haven't exceeded MAX_EVENT_THREADS. > Patch is included. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira