[
https://issues.apache.org/jira/browse/TS-975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250167#comment-13250167
]
Leif Hedstrom commented on TS-975:
----------------------------------
Looking at this diff, I don't quite get it:
1) Why is it necessary to save the "results" in the first chunk? You don't use
them anyways. It ought to be fine to just ignore the return value I think?
2) The content length was converted to network order as far as I can tell, so
are you sure it not be converted back?
The added cases for dealing with errors seems good though. Otto, what do you
want to do with this bug?
> server-transform.c broken
> -------------------------
>
> Key: TS-975
> URL: https://issues.apache.org/jira/browse/TS-975
> Project: Traffic Server
> Issue Type: Bug
> Components: Plugins
> Affects Versions: 3.0.0
> Reporter: Otto van der Schaaf
> Assignee: Igor Galić
> Priority: Minor
> Fix For: 3.1.4
>
> Attachments: server-transform.c.diff
>
>
> While playing around with the server-transform plugin example, i noticed it
> was broken. After some meddling around, i got it working again.
> The changes are mainly that in some cases content-length was passed in
> network-byte order where it shouldn't be.
> Another fix was handling the TS_EVENT_IMMEDIATE event
> in transform_write_event(). i currently perform
> a TSVIOReenable(data->server_vio); on that event, and it seems to work.
> However, I'm not sure at all if that is the correct thing to do, so if
> anybody could help me out on that? :-).
> I have tested the changed code with a custom echo server, and confirmed that
> the plugin is actually sending and receiving to the echo server.
> I added the working code.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
