[ 
https://issues.apache.org/jira/browse/TS-1208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13258890#comment-13258890
 ] 

Igor Galić commented on TS-1208:
--------------------------------

First off, the above patch is explicitly not donated to the ASF, I suppose 
that's an accident.

{code}
+  //    and we should try to summary up if the swap really make the
+  //    server not enough memory? should we take care of the memory
{code}
is better expressed as {{and we should try to summarize whether the swapping is 
really putting the server under memory pressure.}}

The backdoor port stuff has nothing to do with {{check_memory()}} and should 
not be in the same patch!

{{+    // simple heuristic for linux 2.2.x}}

now no longer applies and needs to be changed.
                
> check_memory() in traffic_cop never active on linux
> ---------------------------------------------------
>
>                 Key: TS-1208
>                 URL: https://issues.apache.org/jira/browse/TS-1208
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: Management
>    Affects Versions: 3.1.3
>            Reporter: Zhao Yongming
>            Assignee: Zhao Yongming
>             Fix For: 3.1.4
>
>         Attachments: TS-1208.patch
>
>
> check_memory() will check system memory usage to prevent OOM. and it is still 
> on linux v2.2 codes.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


Reply via email to