[
https://issues.apache.org/jira/browse/TS-1236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13265895#comment-13265895
]
Alan M. Carroll commented on TS-1236:
-------------------------------------
Isn't it wonderful that we have redundant socket creation code so that you
can't mess everything up with one patch?
This looks good to me. My primary comment would be whether we want to support
filter control on a per port basis. That is, add something to HttpProxyPort for
this. In that case you would move the global config option checking to
HttpProxyPort::processOptions. That would check for the port option and if not
found, use the global config setting (proxy.config.net.defer_accept). The local
socket binding code would then always just check the HttpProxyPort data, or
that would be passed down to the iocore socket code. I don't know enough about
the defer accept use case to say if this would be a good idea.
> HTTP Accept filters do not work on Illumos
> ------------------------------------------
>
> Key: TS-1236
> URL: https://issues.apache.org/jira/browse/TS-1236
> Project: Traffic Server
> Issue Type: Bug
> Components: Core
> Affects Versions: 3.1.3
> Environment: Illumos (OmniOS)
> Reporter: Theo Schlossnagle
> Assignee: Theo Schlossnagle
> Priority: Minor
> Attachments: LocalManager-acceptfilt.patch, TS-1236.diff
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> The path for creating the socket() and binding happen outside of the
> previously used code path.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
