[ 
https://issues.apache.org/jira/browse/TS-1297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13292575#comment-13292575
 ] 

Leif Hedstrom commented on TS-1297:
-----------------------------------

James: Can you review this please?

{code}
diff --git a/build/lzma.m4 b/build/lzma.m4
index 482ec14..ecf827e 100644
--- a/build/lzma.m4
+++ b/build/lzma.m4
@@ -89,7 +89,7 @@ if test "$enable_lzma" != "no"; then
     TS_FLAG_HEADERS(lzma.h, [lzma_have_headers=1])
   fi
   if test "$lzma_have_headers" != "0"; then
-    TS_ADDTO(LIBS, [-llzma])
+    AC_SUBST(LIBLZMA, [-llzma])
   else
     enable_lzma=no
     CPPFLAGS=$saved_cppflags
diff --git a/build/zlib.m4 b/build/zlib.m4
index 50fbe02..d08b88b 100644
--- a/build/zlib.m4
+++ b/build/zlib.m4
@@ -89,7 +89,7 @@ if test "$enable_zlib" != "no"; then
     TS_FLAG_HEADERS(zlib.h, [zlib_have_headers=1])
   fi
   if test "$zlib_have_headers" != "0"; then
-    TS_ADDTO(LIBS, [-lz])
+    AC_SUBST(LIBZ, [-lz])
   else
     enable_zlib=no
     CPPFLAGS=$saved_cppflags
diff --git a/proxy/Makefile.am b/proxy/Makefile.am
index 835dd15..69c9c2a 100644
--- a/proxy/Makefile.am
+++ b/proxy/Makefile.am
@@ -166,6 +166,7 @@ traffic_server_LDADD = \
   @LIBTHREAD@ @LIBSOCKET@ @LIBNSL@ @LIBRESOLV@ @LIBRT@ \
   @LIBPCRE@ @LIBSSL@ @LIBTCL@ @LIBDL@ \
   @LIBEXPAT@ @LIBDEMANGLE@ @LIBICONV@ @LIBCAP@ @LIBHWLOC@ \
+  @LIBZ@ @LIBLZMA@ \
   @LIBMLD@ @LIBEXC@ -lm @LIBPROFILER@ @LIBEXECINFO@
 
 traffic_logcat_SOURCES = logcat.cc
@@ -259,7 +260,7 @@ traffic_sac_LDADD = \
   @LIBTHREAD@ @LIBSOCKET@ @LIBNSL@ @LIBRESOLV@ @LIBRT@ \
   @LIBPCRE@ @LIBSSL@ @LIBTCL@ @LIBDL@ \
   @LIBEXPAT@ @LIBDEMANGLE@ @LIBMLD@ @LIBEXC@ @LIBICONV@ -lm @LIBPROFILER@ \
-  @LIBEXECINFO@
+  @LIBZ@ @LIBLZMA@ @LIBEXECINFO@
 
 if BUILD_TESTS
   traffic_sac_LDADD += RegressionSM.o
{code}
                
> Why are all binaries linking with libz and libmza ?
> ---------------------------------------------------
>
>                 Key: TS-1297
>                 URL: https://issues.apache.org/jira/browse/TS-1297
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: Build
>            Reporter: Leif Hedstrom
>            Assignee: Leif Hedstrom
>            Priority: Trivial
>             Fix For: 3.3.0
>
>
> Same problem as TS-1296.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to