[ 
https://issues.apache.org/jira/browse/TS-1633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13539005#comment-13539005
 ] 

Yakov Kopel commented on TS-1633:
---------------------------------

On second thought, there is a problem with this patch.
The max updating is done only when the sync function is activated, so it not 
really max.
Maybe the right way is rewrite the stats handling and moving to atomic 
variables, so we don't need to use thread summarize (sync) function.
using atomic variable for stats that is shared between all the net thread can 
be good idea.
It can fix another issue that stat can be handled only in net-threads and not 
in another threads.
                
> add new stat sync type: TS_STAT_SYNC_MAX
> ----------------------------------------
>
>                 Key: TS-1633
>                 URL: https://issues.apache.org/jira/browse/TS-1633
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: Stats
>            Reporter: Yakov Kopel
>         Attachments: stat_max_ver_1.diff
>
>
> Adding a new stat sync type - max.
> This is a good type of stat to find peaks in the stats.
> It can be very useful with the stat clear api (after the fix - TS-1631).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to