[ 
https://issues.apache.org/jira/browse/TS-1405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13618129#comment-13618129
 ] 

John Plevyak commented on TS-1405:
----------------------------------

I missed on case, fixed in v11. 

I agree that you won't see the race if the timeout (50msec) is sufficiently 
large and no thread fails to be rescheduled and run in that amount of time, but 
I think such timing dependent behavior is to be avoided if possible.  We have 
have a couple other races of this type, uses of new_Freer() and flushing of the 
log buffers but the former use a much larger timeout (1 minute) while the 
latter may be a cause of occasional crashes which we have not been able to 
debug for years.  Experiences with the log buffer flushing issue are why I am 
not happy with a race in the event code.
                
> apply time-wheel scheduler  about event system
> ----------------------------------------------
>
>                 Key: TS-1405
>                 URL: https://issues.apache.org/jira/browse/TS-1405
>             Project: Traffic Server
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 3.2.0
>            Reporter: Bin Chen
>            Assignee: Bin Chen
>             Fix For: 3.3.2
>
>         Attachments: linux_time_wheel.patch, linux_time_wheel_v10jp.patch, 
> linux_time_wheel_v11jp.patch, linux_time_wheel_v2.patch, 
> linux_time_wheel_v3.patch, linux_time_wheel_v4.patch, 
> linux_time_wheel_v5.patch, linux_time_wheel_v6.patch, 
> linux_time_wheel_v7.patch, linux_time_wheel_v8.patch, 
> linux_time_wheel_v9jp.patch
>
>
> when have more and more event in event system scheduler, it's worse. This is 
> the reason why we use inactivecop to handler keepalive. the new scheduler is 
> time-wheel. It's have better time complexity(O(1))

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to