[ 
https://issues.apache.org/jira/browse/TS-1496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13620324#comment-13620324
 ] 

Uri Shachar commented on TS-1496:
---------------------------------

Still looking into this patch -- but a couple of questions/comments:

1) Doesn't really matter, but in P_IOBuffer.h 
IOBufferReader::is_read_avail_more_than, wouldn't it be cleaner to set 
t=block_read_avail() initially, instead of using the start_offset (probably 
also true for IOBufferReader::read_avail)?

2) What would be the use-case for a plugin to register a transform on 
TS_HTTP_RESPONSE_CLIENT_HOOK?

3) What about the opposite use-case, where fast client uploads a large POST to 
a slow server? Different JIRA?

                
> Traffic Server with null-transform buffering large responses when client 
> connection slow
> ----------------------------------------------------------------------------------------
>
>                 Key: TS-1496
>                 URL: https://issues.apache.org/jira/browse/TS-1496
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: HTTP
>    Affects Versions: 3.2.0
>         Environment: Red Hat 6.3
>            Reporter: snf
>            Assignee: Alan M. Carroll
>             Fix For: 3.3.2
>
>         Attachments: ts-1496.diff, TS-1496.patch, TS-1496.patch
>
>
> Scenario:  Traffic Server started with the null-transform plugin.  The link 
> between the client and Traffic Server is slower than the link between the 
> Traffic Server and the Origin Server.
> Affect:  If the client requests a large file from the Origin Server, the 
> whole file can be transmitted to, and buffered by, Traffic Server before 
> content is released to the client.  This is a bigger issue if a large number 
> of clients request large files then the Traffic Server could end up buffering 
> very large amounts of content.
> Expected behaviour:  The Traffic Server should not download all the content 
> from the Origin Server.  Instead, if the client is slow receiving from 
> Traffic Server, then Traffic Server should be slow receiving from the Origin 
> Server.  Traffic Server should facilitate end to end flow control between 
> client and Origin Server.
> Tools to replicate problem:  Use Traffic Control to set a lower bandwidth on 
> the client machine.
> Possible related area in the Traffic Server code:  The following comment 
> appears in proxy/http/Httptunnel.cc
> 48 static void 
> 49 chunked_reenable(HttpTunnelProducer * p, HttpTunnel * tunnel) 
> 50 { 
> 51 
> 52 // FIX ME: still need to deal with huge chunk sizes. If a chunk 
> 53 // is 1GB, we will currently buffer the whole thing 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to