[ 
https://issues.apache.org/jira/browse/TS-1801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13622730#comment-13622730
 ] 

Leif Hedstrom commented on TS-1801:
-----------------------------------

The 90% is roughly correct (it's actually setting the estimated current 
connections to 1.10*conns when checking for throttling), so it's closer to 91% 
I think. I can't see the "half configured" anywhere in the code though.

As for the settings, I much rather add semantics such that setting 
proxy.config.net.connections_throttle to 0 means not to throttle (but, that 
would have bad problems if you run out of FDs, and without external changes to 
ulimit's, you would).
                
> Remove proxy.config.net.throttle_enabled
> ----------------------------------------
>
>                 Key: TS-1801
>                 URL: https://issues.apache.org/jira/browse/TS-1801
>             Project: Traffic Server
>          Issue Type: Improvement
>          Components: Network
>            Reporter: Leif Hedstrom
>            Assignee: Leif Hedstrom
>             Fix For: 3.3.2
>
>
> This setting is fairly nonsensical, and, it seems it was added a while ago 
> when we had issues with leaking FDs and/or stats:
> {code}
> TS_INLINE int
> check_net_throttle(ThrottleType t, ink_hrtime now)
> {
>   if(throttle_enabled == false) {
>     // added by Vijay to disable throttle. This is done find out if
>     // there any other problem other than the stats problem -- bug 3040824
>     return false;
>   }
> {code}
> This setting just makes no sense, because we really honor 
> proxy.config.net.connections_throttle, which also controls the amount of FDs 
> we setrlimit() on.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to