[
https://issues.apache.org/jira/browse/TS-608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13627958#comment-13627958
]
Leif Hedstrom commented on TS-608:
----------------------------------
mohan or weijin:
I do generally like this patch. A question though, why is the new purge code
for per-origin limits removing all connections for that origin? Why not use the
same logic as in fix #1, where you only remove one from each bucket? And even
better, maybe we can refactor the code around the two implementations for
purge_keepalives() such that more of it is used (since they are mostly the
same, or ought to be at least).
Finally, this only deals with IPv4 I think, we need to be able to do this with
both IPv4 and IPv6.
> Is HttpSessionManager::purge_keepalives() too aggressive?
> ----------------------------------------------------------
>
> Key: TS-608
> URL: https://issues.apache.org/jira/browse/TS-608
> Project: Traffic Server
> Issue Type: Bug
> Components: HTTP
> Reporter: Leif Hedstrom
> Fix For: 3.3.2
>
> Attachments: TS-608.patch
>
>
> It seems that if we trigger the "max server connections", we call this purge
> function in the session manager, which will close all currently open
> keep-alive connections. This seems very aggressive, why not limit it to say
> only removing 10% of each "bucket" or some such? Also, how does this work
> together with per-origin limits? Ideally, if the per-origin limits are in
> place, we would only purge sessions that are for the IP we wish to connect to
> ?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
