[ 
https://issues.apache.org/jira/browse/TS-1453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13636624#comment-13636624
 ] 

John Plevyak commented on TS-1453:
----------------------------------

Couple things:  1) the lock is always held over accesses to "disabled" so it 
doesn't need to be volatile 2) I would just change the callback_event to a new 
EVENT_DISABLED and handle it in NetVConnction::mainEvent.   The reason is that 
this will isolate the changes to the net processor, and I think the interaction 
of the disabled flag with the timeouts is problematic: you are going to end up 
rescheduling the event as an immediate eventually which will cause a lot of 
busy processing.
                
> remove InactivityCop and enable define INACTIVITY_TIMEOUT
> ---------------------------------------------------------
>
>                 Key: TS-1453
>                 URL: https://issues.apache.org/jira/browse/TS-1453
>             Project: Traffic Server
>          Issue Type: Sub-task
>          Components: Core
>    Affects Versions: 3.2.0
>            Reporter: Bin Chen
>            Assignee: Bin Chen
>             Fix For: 3.3.5
>
>         Attachments: TS-1453.patch
>
>
> when we have O(1), then we can be enable define INACTIVITY_TIMEOUT

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to