[
https://issues.apache.org/jira/browse/TS-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13647899#comment-13647899
]
James Peach commented on TS-1868:
---------------------------------
Leif, I was reviewing this patch and I don't understand some of the logic in
RemapPlugins::run_single_remap(), particularly around the special handling of
_cur == 0.
For example, this makes no sense:
{code}
// skip the !plugin_modified_* stuff if we are on our 2nd plugin (or greater)
and there's no more plugins
if (_cur > 0 && (_cur + 1) >= map->_plugin_count)
goto done;
{code}
Let's review this tomorrow morning.
> TSREMAP_NO_REMAP_STOP/TSREMAP_DID_REMAP_STOP do not stop remap plugin
> evaluation chain
> --------------------------------------------------------------------------------------
>
> Key: TS-1868
> URL: https://issues.apache.org/jira/browse/TS-1868
> Project: Traffic Server
> Issue Type: Bug
> Components: Remap API
> Reporter: Thach Tran
> Assignee: Leif Hedstrom
> Fix For: 3.3.3
>
> Attachments: remap1.c, remap2.c, remap.config, ts_1868.diff
>
>
> I have several remap plugins that I want to combine in a single remap rule.
> According to the doc, I can chain them in remap.config and if one remap
> plugin return TSREMAP_NO_REMAP_STOP or TSREMAP_DID_REMAP_STOP, the evaluation
> chain will be broken (no further plugin down the chain gets to run).
> However, I have found out that this is not the case. All remap plugins in the
> chain will run regardless of plugins' return code. The only time I see it
> breaks the chain is if a plugin specifies that it wants to return a
> redirection response to the mapped url.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
