[ 
https://issues.apache.org/jira/browse/TS-1891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13655561#comment-13655561
 ] 

James Peach commented on TS-1891:
---------------------------------

Some general comments ....

Memory is either allocated or freed, so it seems like we should only need a 
single bit for this, not a whole refcount?

Is would be great if this was a feature of both freelist allocators. Not sure 
how difficult that would be.

Why is this an option? Surely a double-free is a serious bug and we should 
abort if that happens.

Is this intended for production use by users? If it's primarily for debugging, 
then maybe integrating valgrind or address sanitizer memory poisoning is an 
alternative.

                
> Add double-free checking for reclaimable freelist
> -------------------------------------------------
>
>                 Key: TS-1891
>                 URL: https://issues.apache.org/jira/browse/TS-1891
>             Project: Traffic Server
>          Issue Type: New Feature
>          Components: Core
>            Reporter: Yunkai Zhang
>         Attachments: 
> 0001-Add-double-free-checking-for-reclaimable-freelist.patch
>
>
> double-free checking is very useful for us to analyze memory issues.
> So, I introduce this feature to recalimable freelist.
> The double-free checking for reclaimable freelist is disable by default,
> users can enable it by setting the following option in records.config:
> {code}
>   CONFIG proxy.config.allocator.check_double_free INT 1
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to