[ 
https://issues.apache.org/jira/browse/TS-1889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13658679#comment-13658679
 ] 

James Peach commented on TS-1889:
---------------------------------

First, I didn't realize that the plugin remap was used even when there was no 
plugin. This means that remapping gets skipped. Pretty bad.

Second, url_rewrite_remap_request() does not support all the features that the 
plugin remap code used to support, which is a bit strange. For example, I 
expect that the reverse_map directive would not map the port number. I'd like 
to add the missing features to url_rewrite_remap_request(), though I'm not sure 
how the pristine host header option should behave for reverse_map.

The first case is a trivial fix, so I'll make that change against this ticket, 
The second case is more involved, so I'd like to split that out into TS-1897. 
Does that sound like a reasonable plan?
                
> refactor remap plugin request URL handling
> ------------------------------------------
>
>                 Key: TS-1889
>                 URL: https://issues.apache.org/jira/browse/TS-1889
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: Plugins, Remap API
>            Reporter: James Peach
>            Assignee: James Peach
>             Fix For: 3.3.3
>
>
> Traffic Server always rewrites URLs when it proxies them. The rewrite can be 
> controlled by a configuration file or by code in a loadable plugin. The 
> default URL rewriting code was duplicated for these two cases. This change 
> removes the code duplication from the plugin rewrite case and simplifies the 
> call site. It does not result in any change of behaviour.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to