[
https://issues.apache.org/jira/browse/TS-2106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13736369#comment-13736369
]
ASF subversion and git services commented on TS-2106:
-----------------------------------------------------
Commit 42306ff72404129bec73cfe0900a2c5eb98ce920 in branch
refs/heads/consistent-errors from [~i.galic]
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=42306ff ]
TS-2106: transform all plugins to new logging non-API
some of the experimental plugins are not finished because the libraries
are deep, and not widely used (by me). And then there's the odd one
that doesn't even compile yet..
> Normalize TSError messages in plugins (and examples)
> ----------------------------------------------------
>
> Key: TS-2106
> URL: https://issues.apache.org/jira/browse/TS-2106
> Project: Traffic Server
> Issue Type: Bug
> Components: Plugins
> Reporter: Igor Galić
> Assignee: Igor Galić
> Fix For: 3.5.2
>
>
> right now many of plugins send error messages without prefixing the plugin
> they come from, this bad practice is also continued in our examples.
> many error messages also close with {{\n}}, although this is not necessary.
> We should fix this by "normalizing" the way we send those error messages.
> Our proposal is either:
> {code}
> TSError("%s: cannot parse file %s", PLUGIN_NAME, filename);
> {code}
> or:
> {code}
> TSError("[%s] cannot parse file %s", PLUGIN_NAME, filename);
> {code}
> I have no strong leanings towards either. BUT: We should have one consistent
> format between examples and plugins and newly imported code. The word "error"
> should not be repeated, as it is already in the "severity" ({{TSError()}}.
> There should be *no* {{\n}} at the end of the message.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
