[ 
https://issues.apache.org/jira/browse/TS-2126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13736548#comment-13736548
 ] 

ASF subversion and git services commented on TS-2126:
-----------------------------------------------------

Commit c3a14aafaa1d98b305dc9260814cdae2885a2c60 in branch refs/heads/master 
from [~yunkai]
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=c3a14aa ]

TS-2126: Avoid unnecessary memory copy in LogHost::write()

Now, in LogHost::write (LogBuffer *lb), Another new LogBuffer object will be
allocated to copy the content of *lb* parameter.

But *lb* will be deleted by the upper function, 
LogBufferManager::flush_buffers(),
after LogHost::write() return.

Obviously, the copy is unnecessary, and may cause memory fragmentation.

Let's optimize it.

Signed-off-by: Yunkai Zhang <[email protected]>

                
> Avoid unnecessary memory copy in LogHost::write()
> -------------------------------------------------
>
>                 Key: TS-2126
>                 URL: https://issues.apache.org/jira/browse/TS-2126
>             Project: Traffic Server
>          Issue Type: Improvement
>          Components: Logging
>            Reporter: Yunkai Zhang
>            Assignee: Yunkai Zhang
>         Attachments: 
> 0001-TS-2126-Avoid-unnecessary-memory-copy-in-LogHost-wri.patch
>
>
> Now, in LogHost::write (LogBuffer *lb), Another new LogBuffer object will be 
> allocated to copy the content of *lb* parameter.
> But *lb* will be deleted by the upper function, 
> LogBufferManager::flush_buffers(), after LogHost::write() return.
> Obviously, the copy is unnecessary, and may cause memory fragmentation.
> Let's optimize it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to