[
https://issues.apache.org/jira/browse/TS-2162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13751213#comment-13751213
]
Leif Hedstrom edited comment on TS-2162 at 8/27/13 12:30 PM:
-------------------------------------------------------------
So as per the new policies, this can *not* land on master until v5.0. It's an
incompatible change, that breaks backwards compatibility.
Fwiw, I think you assessment that "most people do this" is wrong. Of all the
times I've done custom logs, I've *never* used a filter. However, I also never
use log collation in production. :)
was (Author: zwoop):
So as per the new policies, this can *not* land on master until v5.0. It's
an incompatible change, that breaks backwards compatibility.
Fwiw, I think you assessment that "most people do this" is wrong. Of all the
times I've done custom logs, I've *never* used a filter.
> Auto-created collation LogObject would be misused by access log
> ---------------------------------------------------------------
>
> Key: TS-2162
> URL: https://issues.apache.org/jira/browse/TS-2162
> Project: Traffic Server
> Issue Type: Bug
> Components: Logging
> Reporter: Yunkai Zhang
>
> When collation host receives LogBuffer data from network, it'll create
> LogObject according the data's format.
> Since the LogFilter of these auto-created LogObjects are empty, they will be
> misused by access log generated by collation host itself -- toss_this_entry()
> will always return false when m_does_conjunction is set.
> I have a simple solution to fix this issue: make toss_this_entry() returns
> true when filter list is empty.
> ==NOTE==
> After apply this solution, user should configure at least one LogFilter for
> each LogObject in logs_xml.config, otherwise the LogObject will be tossed
> always. Luckily, that is what most users do. I will update the comment of
> logs_xml.config.default at the same time to reflect this minor change.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
