[
https://issues.apache.org/jira/browse/TS-2162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yunkai Zhang updated TS-2162:
-----------------------------
Description:
When collation host receives LogBuffer data from network, it'll create
LogObject according the data's format.
Since the LogFilter of these auto-created LogObjects are empty, they will be
misused by access log generated by collation host itself -- toss_this_entry()
will always return false when m_does_conjunction is set.
I have a simple solution to fix this issue: make toss_this_entry() returns true
when filter list is empty.
==NOTE==
After apply this solution, user should configure at least one LogFilter for
each LogObject in logs_xml.config, otherwise the LogObject will be tossed
always. Luckily, that is what most users do. I will update the comment of
logs_xml.config.default at the same time to reflect this minor change.
==Update==
In order to keep backwards compatibility, I thought a new solution: introduces
a new member variable: m_auto_created in LogObject, so that we can distinguish
this type of LogObject to avoid misusing.
I'll give a patch.
was:
When collation host receives LogBuffer data from network, it'll create
LogObject according the data's format.
Since the LogFilter of these auto-created LogObjects are empty, they will be
misused by access log generated by collation host itself -- toss_this_entry()
will always return false when m_does_conjunction is set.
I have a simple solution to fix this issue: make toss_this_entry() returns true
when filter list is empty.
==NOTE==
After apply this solution, user should configure at least one LogFilter for
each LogObject in logs_xml.config, otherwise the LogObject will be tossed
always. Luckily, that is what most users do. I will update the comment of
logs_xml.config.default at the same time to reflect this minor change.
> Auto-created collation LogObject would be misused by access log
> ---------------------------------------------------------------
>
> Key: TS-2162
> URL: https://issues.apache.org/jira/browse/TS-2162
> Project: Traffic Server
> Issue Type: Bug
> Components: Logging
> Reporter: Yunkai Zhang
>
> When collation host receives LogBuffer data from network, it'll create
> LogObject according the data's format.
> Since the LogFilter of these auto-created LogObjects are empty, they will be
> misused by access log generated by collation host itself -- toss_this_entry()
> will always return false when m_does_conjunction is set.
> I have a simple solution to fix this issue: make toss_this_entry() returns
> true when filter list is empty.
> ==NOTE==
> After apply this solution, user should configure at least one LogFilter for
> each LogObject in logs_xml.config, otherwise the LogObject will be tossed
> always. Luckily, that is what most users do. I will update the comment of
> logs_xml.config.default at the same time to reflect this minor change.
> ==Update==
> In order to keep backwards compatibility, I thought a new solution:
> introduces a new member variable: m_auto_created in LogObject, so that we can
> distinguish this type of LogObject to avoid misusing.
> I'll give a patch.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
