[ 
https://issues.apache.org/jira/browse/TS-2163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13754847#comment-13754847
 ] 

ASF subversion and git services commented on TS-2163:
-----------------------------------------------------

Commit a75ebb6372c7e64c415d6fb29d8d24038ee79525 in branch refs/heads/5.0.x from 
[~zwoop]
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=a75ebb6 ]

Merge branch 'master' into 5.0.x

* master: (53 commits)
  Moved the two 4.0.1 changes that we respun build for.
  Added TS-2163
  TS-2163 Remove obsolete WDA and ACC alarms feature
  ci: move jenkins jobs to the jenkins subdirectory
  ci: toggle --enable-wccp correctly for different platforms
  Doc: Add lifecycle hook documentation.
  TS-2145: Add metrics for log collation
  fixed some spelling mistakes in the api header
  TS-2162: Auto-created collation LogObject would be misused by access log
  Some indentation and printf cleanup
  TS-2161: TSHttpTxnHookAdd memory Leak
  TS-2156: Fix stats trap in different type of threads
  doc: move cache glossary into the main glossary
  TS-2160: Update CHANGES.
  TS-2160: Remove ats_is_ip_nonroutable.
  TS-2160: Remove use of ats_is_ip_nonroutable and replace with 
ats_is_ip_linklocal and ats_is_ip_private.
  TS-2160: Add ats_is_ip_private and ats_is_ip_linklocal functions.
  TS-2154: Lua plugin asserts traffic_server on startup
  ci: make git scm polling less aggresive
  ci: flip the 3.4.x branch to 4.0.x
  ...

                
> Remove WDA_BILLING, ACC_ALARMS etc. code and definitions
> --------------------------------------------------------
>
>                 Key: TS-2163
>                 URL: https://issues.apache.org/jira/browse/TS-2163
>             Project: Traffic Server
>          Issue Type: Improvement
>          Components: TS API
>            Reporter: Leif Hedstrom
>            Assignee: Leif Hedstrom
>             Fix For: 4.1.0
>
>
> These defines and API was designed for a specific Inktomi customer, which 
> asked for their own set of alarms for their plugin. This is useless IMO, and 
> we should remove it. IF long term we want extensible alarm codes, a different 
> solution should be put in place (one where plugins can register alarms and 
> alarms definitions).
> Please voice your objections to this if you feel that these should stay:
> {code}
> -#define REC_ALARM_WDA_BILLING_CONNECTION_DIED   100
> -#define REC_ALARM_WDA_BILLING_CORRUPTED_DATA    101
> -#define REC_ALARM_WDA_XF_ENGINE_DOWN            102
> -#define REC_ALARM_WDA_RADIUS_CORRUPTED_PACKETS  103
> -
> -#define REC_ALARM_ACC_ALARMS_START              200
> -#define REC_ALARM_ACC_ALARMS_END                299
> {code}
> and from ts/experimental.h (oxygen was the Inktomi customer I think):
> {code}
> -  typedef enum
> -    {
> -      TS_SIGNAL_WDA_BILLING_CONNECTION_DIED = 100,
> -      TS_SIGNAL_WDA_BILLING_CORRUPTED_DATA = 101,
> -      TS_SIGNAL_WDA_XF_ENGINE_DOWN = 102,
> -      TS_SIGNAL_WDA_RADIUS_CORRUPTED_PACKETS = 103
> -    } TSAlarmType;
> -
> -  /* ===== Alarm ===== */
> -  
> /****************************************************************************
> -   *  ??
> -   *  contact: OXYGEN
> -   
> ****************************************************************************/
> -  tsapi void TSSignalWarning(TSAlarmType code, char *msg);
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to