[ 
https://issues.apache.org/jira/browse/TS-2107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13757759#comment-13757759
 ] 

Leif Hedstrom commented on TS-2107:
-----------------------------------

One more question:

This code looks like it was adding a new functionality, removing a timeout 
where we did not before. Should this be added back after I revert? Please take 
a look at the revert I had to do as well.

{code}
@@ -3268,6 +3289,7 @@ HttpSM::tunnel_handler_post_ua(int event, 
HttpTunnelProducer * p)
   case VC_EVENT_ACTIVE_TIMEOUT:
     //  Did not complete post tunnling.  Abort the
     //   server and close the ua
+    ua_session->get_netvc()->cancel_active_timeout();
     p->handler_state = HTTP_SM_POST_UA_FAIL;
     tunnel.chain_abort_all(p);
     p->read_vio = NULL;
@@ -3297,6 +3319,7 @@ HttpSM::tunnel_handler_post_ua(int event, 
HttpTunnelProducer * p)
     p->handler_state = HTTP_SM_POST_SUCCESS;
     p->read_success = true;
     ua_entry->in_tunnel = false;
+    ua_session->get_netvc()->cancel_active_timeout();
 
     if (p->do_dechunking || p->do_chunked_passthru) {
       if (p->chunked_handler.truncation) {
{code}

                
> add absolute proxy.config.http.transaction_active_timeout_in  about request
> ---------------------------------------------------------------------------
>
>                 Key: TS-2107
>                 URL: https://issues.apache.org/jira/browse/TS-2107
>             Project: Traffic Server
>          Issue Type: New Feature
>          Components: HTTP
>    Affects Versions: 3.3.5
>            Reporter: Bin Chen
>            Assignee: Bin Chen
>             Fix For: 5.0.0
>
>         Attachments: TS-2107.patch
>
>
> Now, ts use proxy.config.http.transaction_active_timeout_in handle request 
> and response transaction. But in some very bad network, we catch some log 
> that it cost >30s to get ua_read_header_done, that is unacceptable, should be 
> controled with some dedicated timeout in records.config.
> we world prefer to add proxy.config.http.transaction_header_timeout_in 
> proxy.config.http.transaction_request_timeout_in
> {code}
> [Aug  6 22:11:46.698] Server {0x2b37cf0f9700} ERROR: [1366077161] Slow 
> Request: url: http://xxxxx/853771125_1448036722.jpg status: 0 unique id:  
> bytes: 0 fd: 0 client state: 0 server state: 0 ua_begin: 0.000 
> ua_read_header_done: 46.790 cache_open_read_begin: 46.790 
> cache_open_read_end: -1.000 dns_lookup_begin: -1.000 dns_lookup_end: -1.000 
> server_connect: -1.000 server_first_read: -1.000 server_read_header_done: 
> -1.000 server_close: -1.000 ua_close: 46.790 sm_finish: 46.790
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to