[
https://issues.apache.org/jira/browse/TS-2180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Leif Hedstrom updated TS-2180:
------------------------------
Description:
I think this is a leak:
{code}
diff --git a/lib/records/RecCore.cc b/lib/records/RecCore.cc
index 4571eef..6b3f58b 100644
--- a/lib/records/RecCore.cc
+++ b/lib/records/RecCore.cc
@@ -185,8 +185,6 @@ RecCoreInit(RecModeT mode_type, Diags *_diags)
// read configs
if ((mode_type == RECM_SERVER) || (mode_type == RECM_STAND_ALONE)) {
ink_mutex_init(&g_rec_config_lock, NULL);
- g_rec_config_contents_llq = create_queue();
- g_rec_config_contents_ht =
ink_hash_table_create(InkHashTableKeyType_String);
// Import the file into memory; try the following in this order:
// ./etc/trafficserver/records.config.shadow
// ./records.config.shadow
{code}
James, can you review? I think it comes from a previous refactoring.
was:
I think this is a leak:
{code}
diff --git a/lib/records/RecCore.cc b/lib/records/RecCore.cc
index 4571eef..6b3f58b 100644
--- a/lib/records/RecCore.cc
+++ b/lib/records/RecCore.cc
@@ -185,8 +185,6 @@ RecCoreInit(RecModeT mode_type, Diags *_diags)
// read configs
if ((mode_type == RECM_SERVER) || (mode_type == RECM_STAND_ALONE)) {
ink_mutex_init(&g_rec_config_lock, NULL);
- g_rec_config_contents_llq = create_queue();
- g_rec_config_contents_ht =
ink_hash_table_create(InkHashTableKeyType_String);
// Import the file into memory; try the following in this order:
// ./etc/trafficserver/records.config.shadow
// ./records.config.shadow
{core}
James, can you review? I think it comes from a previous refactoring.
> Small memory leak in RecCore.cc
> -------------------------------
>
> Key: TS-2180
> URL: https://issues.apache.org/jira/browse/TS-2180
> Project: Traffic Server
> Issue Type: Bug
> Components: Logging
> Reporter: Leif Hedstrom
>
> I think this is a leak:
> {code}
> diff --git a/lib/records/RecCore.cc b/lib/records/RecCore.cc
> index 4571eef..6b3f58b 100644
> --- a/lib/records/RecCore.cc
> +++ b/lib/records/RecCore.cc
> @@ -185,8 +185,6 @@ RecCoreInit(RecModeT mode_type, Diags *_diags)
> // read configs
> if ((mode_type == RECM_SERVER) || (mode_type == RECM_STAND_ALONE)) {
> ink_mutex_init(&g_rec_config_lock, NULL);
> - g_rec_config_contents_llq = create_queue();
> - g_rec_config_contents_ht =
> ink_hash_table_create(InkHashTableKeyType_String);
> // Import the file into memory; try the following in this order:
> // ./etc/trafficserver/records.config.shadow
> // ./records.config.shadow
> {code}
> James, can you review? I think it comes from a previous refactoring.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
