[ 
https://issues.apache.org/jira/browse/TS-2168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13761072#comment-13761072
 ] 

David Carlin edited comment on TS-2168 at 9/7/13 5:06 PM:
----------------------------------------------------------

Why not:

1) proxy.config.allocator.enable_reclaim = 1 in RecordsConfig.cc
2) proxy.config.allocator.enable_reclaim = 1 in records.config

and most important

3) Put a note in records.config that says "This setting has no effect unless 
compiled with --enable-reclaimable-freelist"

If someone compiled with --enable-reclaimable-freelist they are going to want 
proxy.config.allocator.enable_reclaim = 1 anyways; if they did not compile with 
--enable-reclaimable-freelist the setting doesn't do anything, so its 
effectively set to zero.

When I opened this bug I didn't know you had to use the compile time option 
--enable-reclaimable-freelist for the setting to do anything.  Putting that 
info in records.config description will help.
                
      was (Author: dcarlin):
    Why not:

1) proxy.config.allocator.enable_reclaim = 1 in RecordsConfig.cc
2) proxy.config.allocator.enable_reclaim = 1 in records.config

and most important

3) Put a note in records.config that says "This setting has no effect unless 
compiled with --enable-reclaimable-freelist"

If someone compiled with --enable-reclaimable-freelist they are going to want 
proxy.config.allocator.enable_reclaim = 1 anyways; if they did not compile with 
--enable-reclaimable-freelist the setting doesn't do anything, so its 
effectively set to zero.

I opened this bug I didn't know you had to use the compile time option 
--enable-reclaimable-freelist for the setting to do anything.  Putting that 
info in records.config description will help.
                  
> Confusion about proxy.config.allocator.enable_reclaim setting
> -------------------------------------------------------------
>
>                 Key: TS-2168
>                 URL: https://issues.apache.org/jira/browse/TS-2168
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: Configuration
>            Reporter: David Carlin
>            Assignee: Leif Hedstrom
>             Fix For: 4.1.0
>
>         Attachments: 
> 0001-TS-2168-Use-if-condition-to-control-reclaimable-free.patch
>
>
> The default records.config in 4.0.1 says the following which is contradictory:
> {noformat}
> # The value of enable_reclaim should be 0 or 1. Default 1, reclaim enabled.
> CONFIG proxy.config.allocator.enable_reclaim INT 0
> {noformat}
> mgmt/RecordsConfig.cc shows the following:
> {RECT_CONFIG, "proxy.config.allocator.enable_reclaim", RECD_INT, "1", 
> RECU_NULL, RR_NULL, RECC_NULL, "[0-1]", RECA_NULL}
> So the default is 1, but records.config changes it to 0.  

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to