[
https://issues.apache.org/jira/browse/TS-2214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Leif Hedstrom updated TS-2214:
------------------------------
Summary: Suboptimal checks for "buf" in various log tag marshaling (was:
Suboptimal checks for "bug" in various log tag marshaling )
> Suboptimal checks for "buf" in various log tag marshaling
> ----------------------------------------------------------
>
> Key: TS-2214
> URL: https://issues.apache.org/jira/browse/TS-2214
> Project: Traffic Server
> Issue Type: Improvement
> Components: Logging
> Reporter: Leif Hedstrom
> Assignee: Leif Hedstrom
>
> If there is no "buf" to marshal log values into, we ought to abort
> immediately and just return "no data marshaled". This is how things works
> effectively today, it's just that several implementations checks for
> {code}
> if (buf) …
> {code}
> throughout the implementation, instead of just a simple
> {code}
> if (but)
> return INK_MIN_ALIGN;
> {code}
> at the top. Doing this would also clarify the code significantly. An example
> of this is
> {code}
> LogAccessHttp::marshal_http_header_field(LogField::Container container, char
> *field, char *buf);
> {code}
--
This message was sent by Atlassian JIRA
(v6.1#6144)
