[ 
https://issues.apache.org/jira/browse/TS-2488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13870348#comment-13870348
 ] 

Yu Qing edited comment on TS-2488 at 1/14/14 3:28 AM:
------------------------------------------------------

sorry, it's my fault!  
I fixed the bug caused by me.
we should revert the temporary patch 283aa3bca9551067c701d0e2fc1d4ebe313e3d1e, 
then appy my new patch "bugfix-for-TS-2488.patch" to fix this problem.

ps. the output of command "make test" is "all passed", but some cases fail 
actually.
I think this is a bug of Makefile. i 'll report a bug later.

@Kit Chan thank you, I am sorry again.



was (Author: happy_fish100):
sorry, it's my fault!  
I fixed the bug caused by me.
we should revert the temporary patch 283aa3bca9551067c701d0e2fc1d4ebe313e3d1e, 
then appy my new patch "bugfix-for-TS-2488.patch" to fix this problem.

ps. the output of command "make test" is "all passed", but some cases fail 
actually.
I think this is a bug of Makefile. i 'll report a bug later.


> any of the space chars can follow the esi starting tags
> -------------------------------------------------------
>
>                 Key: TS-2488
>                 URL: https://issues.apache.org/jira/browse/TS-2488
>             Project: Traffic Server
>          Issue Type: Improvement
>          Components: Plugins
>            Reporter: Yu Qing
>            Assignee: Kit Chan
>         Attachments: 
> 0001-TS-2488-any-space-char-can-follow-the-esi-starting-t.patch, 2488.txt, 
> bugfix-for-TS-2488.patch
>
>
> only the space char ' ' can follow the esi starting tags such as 
> "<esi:include", "<!--esi" now, we should allow any space char after these 
> tags. the space chars include: ' ', '\t', '\r' and '\n'. 
> for example, following common usage:
> <!--esi
> esi bala bala ...
> -->
> because no space after the "<!--esi", the esi parser will keep these tags 
> which should be removed.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to