[
https://issues.apache.org/jira/browse/TS-645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13876651#comment-13876651
]
James Peach commented on TS-645:
--------------------------------
A few comments about the patch series ...
Pushing this at multiple patches is good, but you need to reorder them so that
each patch builds. So the first patch should remove the callers of
{{StopTrafficServer}}, then the final patch can remove the API.
I'd like to see the TS-645 reference in each patch. Also, I'd like a better
commit log in each. For example, the 2nd patch that removes the clock function
should say which APIs are removed in the subject line, and then describe why it
is ok to remove them in the commit message body.
Anyway I reviewed the series and I'm OK with nuking this. You should also
remove the online help for the {{config:start}}, {{config:stop}} and
{{config:hard-restart}} commands, and update {{config_restart.1}} to explain
exactly what it is doing.
> Hard restart in the mgmt APIs is totally busted
> -----------------------------------------------
>
> Key: TS-645
> URL: https://issues.apache.org/jira/browse/TS-645
> Project: Traffic Server
> Issue Type: Bug
> Components: Management API
> Reporter: Leif Hedstrom
> Assignee: Igor Galić
> Labels: A
> Fix For: 5.0.0
>
>
> In CoreAPIRemote.cc, in HardRestart(), we assume to find some start / stop
> scripts that no longer exists:
> Layout::relative_to(start_path, sizeof(start_path), Layout::get()->bindir,
> "start_traffic_server");
> Layout::relative_to(stop_path, sizeof(stop_path), Layout::get()->bindir,
> "stop_traffic_server");
> I don't know if / when this would be used (probably only in the deprecated
> Web GUI at this point), but we should fix this.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
