[ 
https://issues.apache.org/jira/browse/TS-1256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13876767#comment-13876767
 ] 

James Peach edited comment on TS-1256 at 1/20/14 10:17 PM:
-----------------------------------------------------------

The use of {{PATH_NAME_MAX}} is bogus. It ought to default to the system's 
{{MAXPATHLEN}}.

Though from the source comments, this is done on purpose so that the size is 
constant across platforms. Maybe the places that use {{MAXPATHLEN}} should be 
using {{PATH_NAME_MAX}}.


was (Author: jamespeach):
The use of {{PATH_NAME_MAX}} is bogus. It ought to default to the system's 
{MAXPATHLEN}}.

> Streamline usage of PATH_NAME_MAX
> ---------------------------------
>
>                 Key: TS-1256
>                 URL: https://issues.apache.org/jira/browse/TS-1256
>             Project: Traffic Server
>          Issue Type: Task
>          Components: Cleanup
>            Reporter: Igor Galić
>             Fix For: 5.3.0
>
>
> There are right now two different usages of the constant {{PATH_NAME_MAX}} in 
> variable declarations:
> {code}
> char foo[PATH_NAME_MAX];
> {code}
> and
> {code}
> char bar[PATH_NAME_MAX + 1];
> {code}
> Since we define what {{PATH_NAME_MAX}} is ourselves, we should streamline our 
> code to only use the first kind of declaration.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to