[
https://issues.apache.org/jira/browse/TS-2578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13906233#comment-13906233
]
ASF GitHub Bot commented on TS-2578:
------------------------------------
GitHub user jablko opened a pull request:
https://github.com/apache/trafficserver/pull/42
TS-2578 Close the client connection when you close TransformTerminus
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jablko/trafficserver master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/42.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #42
----
commit 21e67b8c574dbeb68533da7fb7e558fa2e156d18
Author: Jack Bates <[email protected]>
Date: 2014-02-05T17:41:55Z
Reorder some functions so related functions are grouped together
commit 8240d6584b016b962bb92a9108a82d38b27330ce
Author: Jack Bates <[email protected]>
Date: 2014-02-05T17:53:02Z
Rename some variables to more easily disambiguate them
commit 07e418dd884a32a9b7313a38664be1161583ed07
Author: Jack Bates <[email protected]>
Date: 2014-02-05T18:07:44Z
Copy the upstream nbytes (if known) downstream to preserve the
"Content-Length: ..." header. In that case there will be a
TS_EVENT_VCONN_WRITE_COMPLETE event from downstream before ntodo is zero, so
write the digest to the cache in transform_vconn_write_complete(). If the
upstream nbytes isn't known until the end of the content, update the downstream
nbytes and reenable it to get it to send a TS_EVENT_VCONN_WRITE_COMPLETE event.
Fix some memory management.
commit 4b2a7ddd8d6603361199daaa0e7f20e7127205ae
Author: Jack Bates <[email protected]>
Date: 2014-02-05T18:16:59Z
Avoid segfault in TSVIOReenable() if the client disconnected
commit 4f736761fa939f9ec376f225e37a81f6cd8b4b0d
Author: Jack Bates <[email protected]>
Date: 2014-02-05T18:18:54Z
Drop TSVIOBufferGet() and test TSVIOReaderGet() instead
commit d43b8018f3d036bcb0f4b7cdb8beaf06e0ae8103
Author: Jack Bates <[email protected]>
Date: 2014-02-05T18:19:52Z
I don't know what this does
commit 85697757ff54f702351b990f84c9669bf19cc5c7
Author: Jack Bates <[email protected]>
Date: 2014-02-05T19:01:40Z
Improve comments
commit 274a45f13d11c52374f692222cdaf8f9aa3635db
Author: Jack Bates <[email protected]>
Date: 2014-02-05T19:06:50Z
Minor edits
commit 943364c2ba60026a7b289091deb5960ef6097580
Author: Jack Bates <[email protected]>
Date: 2014-02-05T20:08:30Z
TS-2553 CHANGES
commit 69d38bcabf56354af2753e5df469648d66034baa
Author: Jack Bates <[email protected]>
Date: 2014-02-19T22:01:47Z
TS-2578 Close the client connection when you close TransformTerminus
commit b08e0b8e68e8d2ee97e3b2eb3395a35acb0e8a87
Author: Jack Bates <[email protected]>
Date: 2014-02-19T22:29:45Z
Merge remote branch 'upstream/master'
Conflicts:
CHANGES
----
> TSVConnAbort(output_vc) doesn't close the client connection
> -----------------------------------------------------------
>
> Key: TS-2578
> URL: https://issues.apache.org/jira/browse/TS-2578
> Project: Traffic Server
> Issue Type: Bug
> Reporter: Jack Bates
>
> If a transform has sent any content downstream before it decides to call
> TSVConnAbort(output_vc) or TSVConnClose(output_vc) then the client connection
> doesn't get closed.
> If TransformTerminus::handle_event() sends VC_EVENT_ERROR or VC_EVENT_EOS
> events then the client connection does get closed, but it only sends these if
> m_called_user is false. After any content has been sent downstream,
> m_called_user is true.
> One possible solution is to fix the logic in
> TransformTerminus::handle_event() so it sends these events.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
